Fix multiple filter options logic for podman volume ls
#19269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
reviewed
Jul 17, 2023
jakecorrenti
force-pushed
the
volume-ls-mult-filters
branch
from
f24cb3b to
12dad01
Compare
github-actions
bot
added
the
kind/api-change
jakecorrenti
force-pushed
the
volume-ls-mult-filters
branch
from
12dad01 to
de0dfb8
Compare
|
Either CI is broken or this needs a restart |
|
Looks like common infra flakes, you can restart them then it should pass. |
Fixes a bug where `podman volume ls` with multiple `label` filters would return volumes that matched *any* of the filters, not *all* of them. Adapts generating volume filter functions to be more in line with how it is done for containers and pods. Fixes: containers#19219 Signed-off-by: Jake Correnti <[email protected]>
jakecorrenti
force-pushed
the
volume-ls-mult-filters
branch
from
de0dfb8 to
9624115
Compare
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@TomSweeneyRedHat any chance you could push this over the finish line? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakecorrenti, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
podman volume lswith multiplelabelfilters would return volumes that matched any of the filters, not all of them.Fixes: #19219
Does this PR introduce a user-facing change?