Use constants for mount types #19241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
kind/api-change
Inspired by containers#19238 Signed-off-by: Daniel J Walsh <[email protected]>
Luap99
reviewed
Jul 14, 2023
| @@ -1962,7 +1962,7 @@ func (c *Container) makeBindMounts() error { | |||
| case m.Destination == "/run/.containerenv": | |||
| hasRunContainerenv = true | |||
| break Loop | |||
| case m.Destination == "/run" && m.Source != "tmpfs": | |||
| case m.Destination == "/run" && m.Source != define.TypeTmpfs: | |||
There was a problem hiding this comment.
not related to this change this must compare m.Type
There was a problem hiding this comment.
@Luap99 im going to merge this ... do you wanna make a quick pr afterwards to fix this?
|
/hold |
openshift-ci
bot
added
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
rhatdan
added a commit
to rhatdan/podman
that referenced
this pull request
Jul 15, 2023
Paul found this in containers#19241 [NO NEW TESTS NEEDED] Signed-off-by: Daniel J Walsh <[email protected]>
dfr
added a commit
to dfr/common
that referenced
this pull request
Jul 17, 2023
This fixes a regression in containers/podman#19241 which quite reasonably assumed that the default image volume mode from pkg/config was correct. Signed-off-by: Doug Rabson <[email protected]>
dfr
added a commit
to dfr/common
that referenced
this pull request
Jul 17, 2023
This fixes a regression in containers/podman#19241 which quite reasonably assumed that the default image volume mode from pkg/config was correct. Signed-off-by: Doug Rabson <[email protected]>
ashley-cui
pushed a commit
to ashley-cui/podman
that referenced
this pull request
Jul 20, 2023
Paul found this in containers#19241 [NO NEW TESTS NEEDED] Signed-off-by: Daniel J Walsh <[email protected]>
dfr
added a commit
to dfr/common
that referenced
this pull request
Jul 21, 2023
This fixes a regression in containers/podman#19241 which quite reasonably assumed that the default image volume mode from pkg/config was correct. Signed-off-by: Doug Rabson <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #19238
Does this PR introduce a user-facing change?