Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.6 backport] [CI:BUILD] Packit: downstream task action fix #19223

Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jul 13, 2023

The downstream pre-sync task action script needs GOPATH to be specified for the golist tool mentioned in the script to work.

[NO NEW TESTS NEEDED]

(cherry picked from commit 12dc546)

Does this PR introduce a user-facing change?

None

Ok to miss v4.6.0-rc2. Would like to get this in by v4.6.0 release.

cherrypick command failed on #19216 so I'm doing it manually.

@containers/podman-maintainers PTAL

The downstream `pre-sync` task action script needs GOPATH to be
specified for the golist tool mentioned in the script to work.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
(cherry picked from commit 12dc546)
Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@ashley-cui
Copy link
Member

let's get this into rc2 :)

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit af2d788 into containers:v4.6 Jul 13, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
@lsm5 lsm5 deleted the v4.6-packit-downstream-fix branch October 25, 2024 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants