Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] libpod: use new libcontainer blockIO constructors #19212

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

haircommander
Copy link
Collaborator

[NO NEW TESTS NEEDED]

needed for cri-o branch 1.26 (which no longer builds with 4.3 because we use a newer c/storage and c/image 😢 ), no release needed

Does this PR introduce a user-facing change?

none

[NO NEW TESTS NEEDED]

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
Copy link
Collaborator Author

sorry for the noise folks, @mheon @Luap99 @lsm5 @vrothberg @rhatdan PTAL

@Luap99
Copy link
Member

Luap99 commented Jul 12, 2023

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4213001 into containers:v4.4 Jul 12, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants