Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.3] libpod: use new libcontainer blockIO constructors #19209

Merged
merged 1 commit into from
Jul 12, 2023
Merged

[4.3] libpod: use new libcontainer blockIO constructors #19209

merged 1 commit into from
Jul 12, 2023

Conversation

haircommander
Copy link
Collaborator

[NO NEW TESTS NEEDED]

needed for cri-o branch 1.26, no release needed

Does this PR introduce a user-facing change?

none

@haircommander
libpod: use new libcontainer blockIO constructors
7aa1988 
[NO NEW TESTS NEEDED]

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
Copy link
Collaborator Author

@mheon @Luap99 @lsm5 @vrothberg PTAL

vrothberg
vrothberg approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@lsm5
Copy link
Member

lsm5 commented Jul 12, 2023

LGTM

Luap99
Luap99 reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@rhatdan rhatdan merged commit 0a98459 into containers:v4.3 Jul 12, 2023
@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2023

@cevich looks like we need to remove cross compiler option from this branch?

@cevich
Copy link
Member

cevich commented Jul 25, 2023

looks like we need to remove cross compiler option from this branch?

Uh-oh, is this the right branch?

I'm not maintaining CI on this old (non-RHEL) release-branch (standard-practice once v4.4 went out). It's by pure chance that CI worked on this PR at all. I didn't check: Should these changes be cherry-picked into a -rhel release branch (where CI is maintained)?

@haircommander
Copy link
Collaborator Author

no this is only needed for CRI-O which vendors these versions, no need to make it into a podman binary anywhere

@cevich
Copy link
Member

cevich commented Jul 25, 2023

Thanks Peter.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@vrothberg vrothberg vrothberg approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haircommander @lsm5 @rhatdan @cevich @vrothberg @Luap99