[CI:DOCS] podman-system-service.1.md: document systemd usage #19084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriksjolund
force-pushed
the
add_docs_to_system_service
branch
from
b019869 to
125ea66
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
eriksjolund
changed the title
openshift-ci
bot
added
the
approved
|
I plan to rewrite it a bit. (No need for reviews right now) |
eriksjolund
force-pushed
the
add_docs_to_system_service
branch
2 times, most recently
from
f12dfc5 to
aa2cd13
Compare
eriksjolund
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
I rewrote most parts of the first version. I moved some already existing text when I reorganised the document. Should I split up the commit into multiple commit to make it easier to follow how the already existing |
eriksjolund
force-pushed
the
add_docs_to_system_service
branch
4 times, most recently
from
ef0745f to
e959c7b
Compare
Regarding "The command does not support more than one listening socket for the API service." See this Podman source code: (a permalink into the main branch as of 2 July 2023) https://github.com/containers/podman/blob/539be58163a1730af0d84b39fcde585983cd9925/cmd/podman/system/service_abi.go#L48-L50 Move up the paragraph "The REST API provided ...". Move up the sentence "Note: The default systemd ...". Signed-off-by: Erik Sjölund <[email protected]>
eriksjolund
force-pushed
the
add_docs_to_system_service
branch
from
e959c7b to
f907768
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eriksjolund, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?
(I didn't document how it works on macOS and Windows)