[v4.6] 4.6 Backports #19072
Merged
[v4.6] 4.6 Backports #19072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For pods with bridged and slirp4netns networking we create /etc/hosts entries to make it more convenient for the containers to address each other. We omitted to do this for pasta networking, however. Add the necessary code to do this. Closes: containers#17922 Signed-off-by: David Gibson <[email protected]>
This adds the 'system service' command to the build on FreeBSD and suppresses the call to servicereaper.Start which is only needed to support slirp4netns on Linux. A stub for compat.StatsContainer is also added - stats are still supported via the libpod.StatsContainer API call. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
The /var/run directory is the preferred location for unix domain sockets. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
This flag is not supported on BSD-derived systems including FreeBSD and macos. We can get exactly the same symlink by passing the desired relative path as source argument to 'ln -sf'. Signed-off-by: Doug Rabson <[email protected]>
When debugging containers#17403, the logs of sshd indicates that Podman tried to ssh into the machine too soon as the `core` user has not yet been fully set up: > error: kex_exchange_identification: Connection closed by remote host > fatal: Access denied for user core by PAM account configuration [preauth] @dustymabe found that the we may have to wait for systemd-user sessions to be up. Doing that reduces the flake rate on my M2 machine but does not entirely fix the issue. Since I have seen multiple symptoms of flakiness, I think it does not hurt to add the systemd-user sessions to the dependencies of the ready service and continue investigating. [NO NEW TESTS NEEDED] - once we have a fix out, I want to exercise frequent stop/start in the machine tests but they won't pass now. Signed-off-by: Valentin Rothberg <[email protected]>
GetKeepIDMapping never read the gid (as it intended) but reused the uid. Most likely a typo that never bothered anybody as uid and gid usually match. Signed-off-by: Simon Brakhane <[email protected]>
Fix: containers#19033 Signed-off-by: Black-Hole1 <[email protected]>
openshift-ci
bot
added
release-note-none
approved
github-actions
bot
added
the
kind/api-change
At various points the pasta bats tests need to know the name of the interface that pasta will use by default, and the host addresses it will use by default. Currently we use the pre-existing helper functions ether_get_name and ipv[46]_get_addr_global to retreive that. However, those just pick the first non-loopback interface or address, which may not be the one that pasta uses if there are multiple connected host interfaces. Replace those helpers with local ones which examine the routing table to more closely match pasta's internal logic about which interface to select. This allows the tests to run successfully on a host with multiple interfaces. Closes: containers#19007 Signed-off-by: David Gibson <[email protected]>
containers#19021 fixed bugs with the pasta networking tests not working on hosts with multiple interfaces. Alas, the patch left in some stale code that generates spurious error messages for the IPv6 case. This is sort of harmless - later code overrides what's done here and the tests can pass anyway. However if a test fails for some other reason it means we get a misleading irrelevant error message. Signed-off-by: David Gibson <[email protected]>
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?