Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(command): ignore --format in podman search --list-tags #19063

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix(command): ignore --format in podman search --list-tags #19063

merged 1 commit into from
Jun 30, 2023
+12 −1

Conversation

BlackHole1
Copy link
Contributor

@BlackHole1 BlackHole1 commented Jun 30, 2023 •
edited
Loading

Fix: #19033

Does this PR introduce a user-facing change?

Fix ignore `--format` in `podman search --list-tags`

/cc @vrothberg

Luap99
Luap99 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@rhatdan
Copy link
Member

rhatdan commented Jun 30, 2023

/lgtm
/approve
/hold
Thanks @BlackHole1

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlackHole1, Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan rhatdan added the 4.6 label Jun 30, 2023
@ashley-cui
Copy link
Member

/hold cancel
/cherry-pick v4.6

@openshift-cherrypick-robot
Copy link
Collaborator

@ashley-cui: once the present PR merges, I will cherry-pick it on top of v4.6 in a new PR and assign it to you.

In response to this:

/hold cancel
/cherry-pick v4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@openshift-merge-robot openshift-merge-robot merged commit 92a22bb into containers:main Jun 30, 2023
@openshift-cherrypick-robot
Copy link
Collaborator

@ashley-cui: new pull request created: #19069

In response to this:

/hold cancel
/cherry-pick v4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2023
Closed
@BlackHole1 BlackHole1 deleted the fix-search branch June 30, 2023 13:54
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan rhatdan left review comments

@Luap99 Luap99 Luap99 approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman search --list-tags ignores --format
6 participants
@BlackHole1 @rhatdan @ashley-cui @openshift-cherrypick-robot @Luap99 @openshift-merge-robot