Use /proc/self/gid_map as intended, not uid_map #19062
Conversation
|
/approve git commit -a --amend -s |
openshift-ci
bot
added
the
approved
|
Thanks @Luminger |
GetKeepIDMapping never read the gid (as it intended) but reused the uid. Most likely a typo that never bothered anybody as uid and gid usually match. Signed-off-by: Simon Brakhane <[email protected]>
Luminger
force-pushed
the
fix-use-gid-map-not-uid-map
branch
from
d61a7e7 to
94e59bd
Compare
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, Luminger, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick v4.6 |
|
@ashley-cui: once the present PR merges, I will cherry-pick it on top of v4.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ashley-cui: new pull request created: #19071 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github-actions
bot
added
the
locked - please file new issue/PR
GetKeepIDMapping never read the gid (as it intended) but reused the uid. Most likely a typo that never bothered anybody as uid and gid usually match.
I stumbled across this by accident and figured I can just fix it along the way, even though I was not hit by that bug :)
Does this PR introduce a user-facing change?
[NO NEW TESTS NEEDED]