Cirrus: Remove docker-compose v1 testing

[cevich]

Fixes #18688

Docker compose v1 has long since gone EOL and is no longer supported by upstream. Therefore the only things we're accomplishing by testing it with modern Podman are: Wasting time and inviting flakes. Remove it.

Does this PR introduce a user-facing change?

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cevich
Once this PR has been reviewed and has the lgtm label, please assign umohnani8 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

Thanks, can you also remove the f [ "$TEST_FLAVOR" ... statements in the tests since this now is always true.

And please mention in the test Readme that only compose v2 is supported.

[cevich]

can you also remove the f [ "$TEST_FLAVOR" ... statements in the tests

Oh, thanks for noticing. I'll give it a try, though I don't think I've ever even looked sideways at these tests.

And please mention in the test Readme that only compose v2 is supported.

I didn't even realize there was a ReadMe, yep I can fix that. Thanks for the suggestion.

[rhatdan]

LGTM

[cevich]

Force-push: Addressed all of Paul's concerns + rebased.

[Luap99]

LGTM but I think we should wait for @vrothberg or @mheon to weigh in as they expressed concerns on the issue.

[vrothberg]

My position hasn't changed. It doesn't matter to me whether v1 is EOL but that it's widely used (and the only packaged one in Fedora). If it works with Docker and does not work with Podman, we cannot sneak out by saying "it's EOL".

So I think we should ask whether the v1 tests are redundant to others. Remember, we don't test v1 but Podman's compat API. I feel very uncomfortable since the compat API IMO needs more tests not less.

But I won't block on it and I won't say "I told you so" :^) But I won't ACK either.

[Luap99]

So I think we should ask whether the v1 tests are redundant to others. Remember, we don't test v1 but Podman's compat API. I feel very uncomfortable since the compat API IMO needs more tests not less.

Well they are redundant to v2, they should mostly execute the same API calls, sure likely not 100% so we could loose some coverage but I don't think it is noticeable in real world.

If it works with Docker and does not work with Podman, we cannot sneak out by saying "it's EOL".

Sure then they can give us the API calls and we can fix it. We have compat API tests I don't see why we would need to keep compose v1 test for that kind of scenario.
And yes I can and will sneak out if I deem that docker is completely insane in that case, some docker bugs are so incredible dump that I am not going to add them to podman, compare #17990.

[cevich]

it's widely used

So is Windows 7, but you certainly won't get any updates or fixes for that 😀

Alt. (more user-friendly) idea: Is there a way to detect if v1 is being used and print a friendly error message?

[Luap99]

Based on the other compose discussion yesterday I like to change my opinion. I think we can live with these test a bit longer until we know it is no longer in use (e.g. not shipped in fedora).

[cevich]

I think we can live with these test a bit longer until we know it is no longer in use (e.g. not shipped in fedora).

Thanks for the followup Paul. I'll update the issue you opened.