Re-organize hypervisor implementations #18977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Jun 23, 2023
jakecorrenti
force-pushed
the
move-qemu-functions-to-proper-files
branch
from
d2c5134 to
9d89c9c
Compare
|
LGTM |
jakecorrenti
force-pushed
the
move-qemu-functions-to-proper-files
branch
from
9d89c9c to
e05c4fd
Compare
Ensures that for each hypervisor implementation, their `config.go` file deals with implementing the `VirtProvider` interface while the `machine.go` file is for implementing the `VM` interface. Moves the `Virtualization` type into a common file and created wrappers for the individual hypervisors. Allows for shared functions that are exactly the same while providing the flexibility to create hypervisor-specific implementations of the functions. [NO NEW TESTS NEEDED] Signed-off-by: Jake Correnti <[email protected]>
jakecorrenti
force-pushed
the
move-qemu-functions-to-proper-files
branch
from
e05c4fd to
5160342
Compare
There was a problem hiding this comment.
LGTM
I restarted a timed out test that looked to be a flake. I would like a @bbaude head nod on this.
|
@baude @ashley-cui PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakecorrenti, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that for each hypervisor implementation, their
config.gofile deals with implementing theVirtProviderinterface while themachine.gofile is for implementing theVMinterface.Moves the
Virtualizationtype into a common file and created wrappers for the individual hypervisors. Allows for shared functions that are exactly the same while providing the flexibility to create hypervisor-specific implementations of the functions.[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?