bump golangci-lint to v1.53.3 #18931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable new linters and drop comments on them. Signed-off-by: Valentin Rothberg <[email protected]>
Helpful reports to avoid unnecessary allocations. Signed-off-by: Valentin Rothberg <[email protected]>
Because we shouldn't waste assigns. Signed-off-by: Valentin Rothberg <[email protected]>
It turns out, after iterating over rows, we need to check for errors. It also turns out that we did not do that at all. Signed-off-by: Valentin Rothberg <[email protected]>
openshift-ci
bot
added
release-note-none
approved
Luap99
reviewed
Jun 19, 2023
To make sure the e2e tests are kept in order. Signed-off-by: Valentin Rothberg <[email protected]>
But disable the `unused-parameter` linter as there are just too many reports that I could handle. Also allow unused nolintlint reports. Signed-off-by: Valentin Rothberg <[email protected]>
|
@Luap99 re-enabled and partially disabled ✔️ |
Luap99
reviewed
Jun 19, 2023
Which revealed that absent --authfile's are ignored but shouldn't. The issue is now being tracked in containers#18938. Signed-off-by: Valentin Rothberg <[email protected]>
Luap99
reviewed
Jun 20, 2023
Let's make sure to always specify the expected exit codes, even in case of failure. Signed-off-by: Valentin Rothberg <[email protected]>
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially disable new linter (warnings). Also fix some straight away as the warnings concerned me, especially the sql error checks. Please refer to the individual commits for details.
Does this PR introduce a user-facing change?