container wait: indicate timeout in error #18869
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Not sure how this helps to debug #18860? It is obvious to me that we hit the timeout in the flake. Regardless this change LGTM, should give us some clarity without looking at the timings, especially if we start seeing these in the wild. |
I strongly suspect so as well but without the log I cannot be 100 percent sure. |
|
@edsantiago PTAL |
When waiting for a container, there may be a time window where conmon has already exited but the container hasn't been fully cleaned up. In that case, we give the container at most 20 seconds to be fully cleaned up. We cannot wait forever since conmon may have been killed or something else went wrong. After the timeout, we optimistically assume the container to be cleaned up and its exit code to present. If no exit code can be found, we return an error. Indicate in the error whether the timeout kicked in to help debug (transient) errors and flakes (e.g., containers#18860). [NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <[email protected]>
|
LGTM2 |
|
ready to merge |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
When waiting for a container, there may be a time window where conmon has already exited but the container hasn't been fully cleaned up. In that case, we give the container at most 20 seconds to be fully cleaned up. We cannot wait forever since conmon may have been killed or something else went wrong.
After the timeout, we optimistically assume the container to be cleaned up and its exit code to present. If no exit code can be found, we return an error.
Indicate in the error whether the timeout kicked in to help debug (transient) errors and flakes (e.g., #18860).
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?