Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specgen): index out of range when unmask=[] #18849

Merged
merged 2 commits into from
Jun 12, 2023
Merged

fix(specgen): index out of range when unmask=[] #18849

merged 2 commits into from
Jun 12, 2023

Conversation

xtexChooser
Copy link
Contributor

@xtexChooser xtexChooser commented Jun 11, 2023 •
edited
Loading

Fixes #18848

Fixed index out of range error when unmask is set to empty

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Jun 11, 2023
@openshift-ci openshift-ci bot added release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Jun 11, 2023
@xtexChooser
style(specgen): omit nil check
d734fcb 
len(nil) == 0

[NO NEW TESTS NEEDED]

Signed-off-by: xtex <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Jun 11, 2023

Thanks @xtexChooser
/approve
LGTM
@flouthoc @giuseppe @vrothberg @mtrmac @mheon @baude @ashley-cui PTAL

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2023
giuseppe
giuseppe approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan, xtexChooser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 32d96f4 into containers:main Jun 12, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

@giuseppe giuseppe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index out of range when unmask=[]
4 participants
@xtexChooser @rhatdan @giuseppe @openshift-merge-robot