Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add ginkgo decorators to address flakes #18816

Merged
merged 1 commit into from
Jun 7, 2023
Merged

e2e: add ginkgo decorators to address flakes #18816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/e2e/exec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,8 @@ var _ = Describe("Podman exec", func() {
Expect(session.OutputToString()).To(ContainSubstring("0000000000000000"))
})

It("podman exec terminal doesn't hang", func() {
// #10927 ("no logs from conmon"), one of our nastiest flakes
It("podman exec terminal doesn't hang", FlakeAttempts(3), func() {
setup := podmanTest.Podman([]string{"run", "-dti", "--name", "test1", fedoraMinimal, "sleep", "+Inf"})
setup.WaitWithDefaultTimeout()
Expect(setup).Should(Exit(0))
Expand Down
3 changes: 2 additions & 1 deletion test/e2e/search_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,8 @@ registries = ['{{.Host}}:{{.Port}}']`
Expect(search).To(ExitWithError())
})

It("podman search with wildcards", func() {
// Registry is unreliable (#18484), this is another super-common flake
It("podman search with wildcards", FlakeAttempts(3), func() {
search := podmanTest.Podman([]string{"search", "registry.access.redhat.com/*openshift*"})
search.WaitWithDefaultTimeout()
Expect(search).Should(Exit(0))
Expand Down
3 changes: 2 additions & 1 deletion test/e2e/trust_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import (
. "github.com/onsi/gomega/gexec"
)

var _ = Describe("Podman trust", func() {
// Without Ordered, tests flake with "Getting key identity" (#18358)
var _ = Describe("Podman trust", Ordered, func() {

BeforeEach(func() {
SkipIfRemote("podman-remote does not support image trust")
Expand Down