play.go: remove volumes with kube down --force

[danishprakash]

Closes #18797

kube down: remove volumes when --force is specified

Signed-off-by: danishprakash [email protected]

[baude]

/approve
LGTM

[TomSweeneyRedHat]

All kinds of red tests @danishprakash

[danishprakash]

All kinds of red tests @danishprakash

Yeah, I was trying to work around the fact that the volumes created by podman are named differently than what's specified in the k8s manifest. The current solution is in alignment with how we create volumes out of the manifest.

But in the longer run, I believe KubeVolume could have a Name attribute which would be the direct equivalent of the volume name in the k8s manifest. That is of course, I'm missing out on a specific design decision that involved using Source as the volume name for all kinds of volumes (the current implementation).

[rhatdan]

Should we change the naming of kubernetes volumes to match kubernetes?

[danishprakash]

I would say yes, should that come under the scope of this PR or another? I think for the issue this was opened, this change is sufficient. PTAL.

[vrothberg]

One nit on the test, other than that LGTM

@Luap99 PTAL

[vrothberg]

LGTM
@Luap99 PTAL

[Luap99]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, danishprakash, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment