filters: better handling of id= #18798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
approved
edsantiago
force-pushed
the
fix_filters
branch
3 times, most recently
from
365ed47 to
22dabb9
Compare
zhangguanzhang
approved these changes
Jun 6, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, zhangguanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
reviewed
Jun 6, 2023
pkg/domain/filters/containers.go
Outdated
| @@ -18,9 +19,20 @@ import ( | |||
| func GenerateContainerFilterFuncs(filter string, filterValues []string, r *libpod.Runtime) (func(container *libpod.Container) bool, error) { | |||
| switch filter { | |||
| case "id": | |||
| // we only have to match one ID | |||
| hexRegex := regexp.MustCompile("[^0-9a-fA-F]") | |||
There was a problem hiding this comment.
this should be a global variable and use the "github.com/containers/storage/pkg/regexp" package instead.
|
Other thatn @Luap99 's comments, LGTM |
edsantiago
force-pushed
the
fix_filters
branch
2 times, most recently
from
44aca7c to
3bc098a
Compare
For filter=id=XXX (containers, pods) and =ctr-ids=XXX (pods): if XXX is only hex characters, treat it as a PREFIX otherwise, treat it as a REGEX Add tests. Update documentation. And fix an incorrect help message. Fixes: containers#18471 Signed-off-by: Ed Santiago <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For filter=id=XXX:
if XXX is only hex characters, treat it as a PREFIX
otherwise, treat it as a REGEX
Fixes: #18471
Signed-off-by: Ed Santiago [email protected]