Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve get identity path duplicate code #18750

Merged
merged 1 commit into from
Jun 7, 2023
Merged

refactor: improve get identity path duplicate code #18750

merged 1 commit into from
Jun 7, 2023

Conversation

BlackHole1
Copy link
Contributor

Does this PR introduce a user-facing change?

None

@BlackHole1 BlackHole1 force-pushed the improve-ssh branch 2 times, most recently from 2aa7f48 to 504ba68 Compare May 31, 2023 09:08
@BlackHole1 BlackHole1 changed the title refactor: improve get ssh path duplicate code refactor: improve get identity path duplicate code May 31, 2023
@BlackHole1 BlackHole1 force-pushed the improve-ssh branch 5 times, most recently from 5043dea to c75e519 Compare June 2, 2023 03:40
@BlackHole1
Copy link
Contributor Author

Request CR again.
/CC @TomSweeneyRedHat

@openshift-ci openshift-ci bot requested a review from TomSweeneyRedHat June 5, 2023 01:22
@baude
Copy link
Member

baude commented Jun 5, 2023

LGTM

@TomSweeneyRedHat
Copy link
Member

@BlackHole1, thanks for the explanations on my comments. However, I don't have the time to dig deep at the moment, and I don't feel good about adding my own LGTM to this. If others feel more comfortable doing so, I will not hold up the PR.

@BlackHole1
Copy link
Contributor Author

@TomSweeneyRedHat OK, thank you equally for your CR :)

rhatdan
rhatdan reviewed Jun 6, 2023
View reviewed changes
pkg/util/utils_test.go Outdated Show resolved Hide resolved
@rhatdan
Copy link
Member

rhatdan commented Jun 6, 2023

@ashley-cui @cdoern PTAL

@ashley-cui
Copy link
Member

Other than @rhatdan 's comment, LGTM, thanks!

@rhatdan
Copy link
Member

rhatdan commented Jun 7, 2023

/approve
/lgtm
Thanks @BlackHole1

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlackHole1, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 377245d into containers:main Jun 7, 2023
@BlackHole1 BlackHole1 deleted the improve-ssh branch June 7, 2023 12:28
@edsantiago edsantiago mentioned this pull request Jun 20, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashley-cui ashley-cui ashley-cui left review comments

@rhatdan rhatdan rhatdan left review comments

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BlackHole1 @baude @TomSweeneyRedHat @rhatdan @ashley-cui @openshift-merge-robot