DO NOT MERGE: Tests for https://github.com/containers/storage/pull/1607

[mtrmac]

Does this PR introduce a user-facing change?

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mtrmac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtrmac]

This does show failures; this PR now includes #18636, so that one of the failures is correctly reported.

[edsantiago]

@mtrmac I cherry-picked this onto #17831 on Friday, and have been rerunning CI as often as I can .... and the failure has not triggered :-(

[mtrmac]

Seeing consistent failures:

[+0026s] not ok 10 network - restart
[+0026s] # (from function `die' in file test/upgrade/../system/helpers.bash, line 565,
[+0026s] #  from function `run_podman' in file test/upgrade/../system/helpers.bash, line 246,
[+0026s] #  in test file test/upgrade/test-upgrade.bats, line 285)
[+0026s] #   `run_podman stop -t0 myrunningcontainer' failed
[+0026s] # [15:07:53.359508914] # podman network disconnect mynetwork myrunningcontainer
[+0026s] # [15:07:53.618602155] # podman stop -t0 myrunningcontainer
[+0026s] # [15:07:53.785161546] Error: unmounting container 200d6108a677d05cff46ffe6249bd9158c41b3591724e1c1cd095fb3769196f9 storage: cleaning up container 200d6108a677d05cff46ffe6249bd9158c41b3591724e1c1cd095fb3769196f9 storage: unmounting container 200d6108a677d05cff46ffe6249bd9158c41b3591724e1c1cd095fb3769196f9 root filesystem: unmounting "/tmp/pu.wZkoM7/root/overlay/e38a5889292f9972b40b5d96a6427fdf168dc46389dd57ed8c33e66072ae2c06/merged": invalid argument
[+0026s] # [15:07:53.791386689] [ rc=125 (** EXPECTED 0 **) ]

Uh, ??

… so adding more logging to see how we got there.

[mtrmac]

The c/storage PR was merged (regardless of test failures here…)