Kube Play - Support multi-doc YAML files for configmap argument #18538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
approved
ygalblum
force-pushed
the
play-multiple-configmaps
branch
from
2c92915 to
92f3681
Compare
Luap99
reviewed
May 11, 2023
test/system/700-play.bats
Outdated
Comment on lines
707
to
709
| run_podman kube play --configmap=$configmap_file $pod_file | ||
| run_podman logs test_pod-server |
There was a problem hiding this comment.
You need to do a podman wait in between to prevent flakes, play just start we do not know if the echo command was executed by the time we run logs. We actually have to make sure the container exited before running logs.
cc @edsantiago
Read the entire YAML file in case of a multi-doc file Adjust the unit test Add a system test Add comment in the man page Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
play-multiple-configmaps
branch
from
92f3681 to
26f1e95
Compare
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the entire YAML file in case of a multi-doc file Adjust the unit test
Add a system test
Add comment in the man page
Resolves: #18537
Does this PR introduce a user-facing change?
Yes