Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] issue template: mention su #18532

Merged
merged 1 commit into from
May 10, 2023

Conversation

vrothberg
Copy link
Member

Mention that using su does not establish a proper login session required for running rootless Podman. It is a common and reoccurring issue. Mentioning that in the issue template may guide users into resolving the issue before opening an issue.

Does this PR introduce a user-facing change?

None

@containers/podman-maintainers PTAL

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2023
@vrothberg vrothberg marked this pull request as ready for review May 10, 2023 09:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2023
@@ -70,7 +70,7 @@ body:
id: privileged_rootless
attributes:
label: Privileged Or Rootless
description: Are you running the containers as privileged or non-root user?
description: Are you running the containers as privileged or non-root user? Note that using `su` does not establish a proper login session required for running Podman as a non-root user.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, you can also link directly to https://github.com/containers/podman/blob/main/troubleshooting.md#solution-28 to show some alternatives

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that! PTanotherL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -70,7 +70,7 @@ body:
id: privileged_rootless
attributes:
label: Privileged Or Rootless
description: Are you running the containers as privileged or non-root user?
description: Are you running the containers as privileged or non-root user? Note that using `su` does not establish a proper login session required for running Podman as a non-root user. Please refer to the [troubleshooting guide](https://github.com/containers/podman/blob/main/troubleshooting.md#solution-28) for alternatives.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that using su or sudo ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✔️

Mention that using `su` does not establish a proper login session
required for running rootless Podman.  It is a common and reoccurring
issue.  Mentioning that in the issue template may guide users into
resolving the issue before opening an issue.

Signed-off-by: Valentin Rothberg <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented May 10, 2023

You can use
machinectl shell USERNAME@

@vrothberg
Copy link
Member Author

Good to merge?

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit d7f9ef2 into containers:main May 10, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants