fix: podman manifest annotate help example should use image digest #18351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanfeng1992
force-pushed
the
ManifestAnotateHelp
branch
3 times, most recently
from
fdbc548 to
b7c81d8
Compare
yanfeng1992
changed the title
yanfeng1992
changed the title
[NO NEW TESTS NEEDED] Signed-off-by: huangyanfeng <[email protected]>
yanfeng1992
force-pushed
the
ManifestAnotateHelp
branch
from
b7c81d8 to
e95e9be
Compare
Luap99
approved these changes
Apr 26, 2023
openshift-ci
bot
added
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan, yanfeng1992 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?
The podman manifest annote does not support the use of image tags. When tags are used, digest.Parse(image) will fail, but the examples in the help use tags, which will mislead users. I think the examples in the help should be changed to sha256:15352d97781ffdf357bf3459c037be3efac4133dc9070c2dce7eca7c05c3e736