-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: fix logs tests about an error message #18279
Conversation
When events_logger is file or none, podman outputs an error message such as following: - local environment `using --follow with the journald --log-driver bug without the journald --events-backend` - remote environment `Error: channel "123" found, 0-3 supported: lost synchronization with multiplexed stream` Signed-off-by: Toshiki Sonoda <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sstosh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering how were the tests passing in CI if error message is different for remote.
I think CI test runs only with the |
I have verified that the error message is different on the main branch.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please wait for 734e6e8 to land, fixing the test is wrong this is a podman bug
@Luap99 WDYT of separating your "123" fix into a separate PR? I think ginkgov2 is not going to merge for a long time, and it would be nice to have the "123" bug fixed in the interim. |
Well I am trying to prove you wrong here, as far as I am concerned I only wait for one bug fix (#18180) after that all tests should be passing. Sure I can split out many fixes, if that is desired I can do it. |
Closing in favour of #18282 |
When
events_logger
isfile
ornone
, podman outputs an error message such as following:local environment
using --follow with the journald --log-driver bug without the journald --events-backend
remote environment
Error: channel "123" found, 0-3 supported: lost synchronization with multiplexed stream
Signed-off-by: Toshiki Sonoda [email protected]
NG log (remote, events_logger = file)
Does this PR introduce a user-facing change?