Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix logs tests about an error message #18279

Closed
wants to merge 1 commit into from

Conversation

sstosh
Copy link
Contributor

@sstosh sstosh commented Apr 20, 2023

When events_logger is file or none, podman outputs an error message such as following:

  • local environment
    using --follow with the journald --log-driver bug without the journald --events-backend

  • remote environment
    Error: channel "123" found, 0-3 supported: lost synchronization with multiplexed stream

Signed-off-by: Toshiki Sonoda [email protected]


NG log (remote, events_logger = file)
~ Failure [0.652 seconds]
Podman logs
/root/podman/test/e2e/logs_test.go:27
  streaming output: journald [It]
  /root/podman/test/e2e/logs_test.go:293

  Expected
      <string>: Error: channel "123" found, 0-3 supported: lost synchronization with multiplexed stream
  to contain substring
      <string>: using --follow with the journald --log-driver but without the journald --events-backend

Does this PR introduce a user-facing change?

None

When events_logger is file or none, podman outputs an error message
such as following:

- local environment
`using --follow with the journald --log-driver bug without
the journald --events-backend`

- remote environment
`Error: channel "123" found, 0-3 supported: lost synchronization
with multiplexed stream`

Signed-off-by: Toshiki Sonoda <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sstosh
Once this PR has been reviewed and has the lgtm label, please assign ygalblum for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering how were the tests passing in CI if error message is different for remote.

@sstosh
Copy link
Contributor Author

sstosh commented Apr 20, 2023

Just wondering how were the tests passing in CI if error message is different for remote.

I think CI test runs only with the events_logger = journald.
So these tests passed.

@sstosh
Copy link
Contributor Author

sstosh commented Apr 20, 2023

I have verified that the error message is different on the main branch.

# podman info | grep eventLogger
  eventLogger: file

# podman-remote run --log-driver journald --name test -dt quay.io/libpod/alpine:latest sh -c echo podman-1; sleep 1; echo podman-2
450c09e073eea520e61ed17b1e1cb6572cb3f8848e7c4c32b031c76daf781fa6
podman-2

# podman-remote logs -f test
Error: channel "123" found, 0-3 supported: lost synchronization with multiplexed stream

# podman logs -f test
Error: using --follow with the journald --log-driver but without the journald --events-backend (file) is not supported

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wait for 734e6e8 to land, fixing the test is wrong this is a podman bug

@edsantiago
Copy link
Member

@Luap99 WDYT of separating your "123" fix into a separate PR? I think ginkgov2 is not going to merge for a long time, and it would be nice to have the "123" bug fixed in the interim.

@Luap99
Copy link
Member

Luap99 commented Apr 20, 2023

I think ginkgov2 is not going to merge for a long time

Well I am trying to prove you wrong here, as far as I am concerned I only wait for one bug fix (#18180) after that all tests should be passing.

Sure I can split out many fixes, if that is desired I can do it.

@Luap99
Copy link
Member

Luap99 commented Apr 20, 2023

Closing in favour of #18282

@Luap99 Luap99 closed this Apr 20, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants