-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix race when listing cgroups #18277
test: fix race when listing cgroups #18277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A cgroup could have been deleted by the time WalkDir is trying to access it. Ignore the error and continue. Closes: containers#17989 Signed-off-by: Giuseppe Scrivano <[email protected]>
d637900
to
0364aef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm
/approve
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel Thanks @giuseppe ! |
A cgroup could have been deleted by the time WalkDir is trying to access it. Ignore the error and continue.
Closes: #17989
Does this PR introduce a user-facing change?