pypodman: Don't use $HOST and $USER variables for remote

[afbjorklund]

Also, don't use $PORT. These are too generic.

Make sure to read $LOGNAME after the config.

---

Makes it hard to configure "root" in pypodman.conf

It will always use $USER, for the ssh login name ?

[TomSweeneyRedHat]

/ok-to-test

[TomSweeneyRedHat]

The change LGTM in what you're attempting to do. I'll let @mheon and @jwhonce weigh in to see if they've issues.

[afbjorklund]

It would be OK to use something specific, like $PYPODMAN_USER and $PYPODMAN_HOST/PORT

I just hid all that complexity in the pypodman.conf file, although that could need a variable instead...

Currently you have to override $XDG_CONFIG_HOME, which also hard (a bad idea) to do globally:

        """Find and fill in any arguments not passed on command line."""
        args.xdg_runtime_dir = os.environ.get('XDG_RUNTIME_DIR', '/tmp')
        args.xdg_config_home = os.environ.get('XDG_CONFIG_HOME',
                                              os.path.expanduser('~/.config'))
        args.xdg_config_dirs = os.environ.get('XDG_CONFIG_DIRS', '/etc/xdg')

Would be better to set $PYPODMAN_CONFIG_HOME, when you want to use a temporary config ?

---

Anyway, this change allows me to not have to use pypodman --username=root all the time...

I will do a separate patch for the variable. Already contributed a patch for $VARLINK_BRIDGE.

[rhatdan]

I believe the variables should be prefixed with PODMAN_ not PYPODMAN. That would give us the flexibility to name the tool podman or podman_remote when installed on a non linux box.

[afbjorklund]

It would also give you the opportunity to use a different language :-)

Maybe the same approach should be taken for the pypodman.conf ?

[afbjorklund]

@jwhonce : added it to all environment variables, for consistency.

[rhatdan]

LGTM

[TomSweeneyRedHat]

LGTM

[rhatdan]

/lgtm

[jwhonce]

LGTM

[rhatdan]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment