-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update module github.com/opencontainers/runtime-spec to v1.1.0-rc.2 #18234
fix(deps): update module github.com/opencontainers/runtime-spec to v1.1.0-rc.2 #18234
Conversation
….1.0-rc.2 Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
It really doesn't make sense to match the version one to one, this just requires us to update it every time manually. Use a regex instead. Signed-off-by: Paul Holzinger <[email protected]>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vrothberg PTAL |
@@ -177,7 +177,7 @@ func TestPostDeleteHooks(t *testing.T) { | |||
if err != nil { | |||
t.Fatal(err) | |||
} | |||
stateRegexp := `{"ociVersion":"1\.1\.0-rc.1","id":"123abc","status":"stopped","bundle":"` + dir + `","annotations":{"a":"b"}}` | |||
stateRegexp := `{"ociVersion":"[0-9]+\.[0-9]+\..*","id":"123abc","status":"stopped","bundle":"` + dir + `","annotations":{"a":"b"}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 great idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, renovate[bot], vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the following updates:
v1.1.0-rc.1
->v1.1.0-rc.2
Release Notes
opencontainers/runtime-spec
v1.1.0-rc.2
Compare Source
Vote: #1192 ( https://groups.google.com/a/opencontainers.org/g/dev/c/fnCiFoXBsiI/m/fbbmbs19EQAJ )
Changes (v1.1.0-rc.1 → v1.1.0-rc.2)
Additions
features.md
to formalize therunc features
JSON (#1130)Minor fixes and documentation
When serialized in JSON, the format MUST adhere to the following pattern
(#1178)Changes (v1.0.2 → v1.1.0-rc.1)
Breaking changes (but rather conforms to the existing runc implementation)
Deprecations
Additions
Minor fixes and documentation
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.