Fixes format inconsistencies with docker for certain history fields

[rbagd]

Closes #17767
Closes #17768

Does this PR introduce a user-facing change?

Fixes a format inconsistency where podman and docker return slightly different output for `history --format {{.CreatedAt}}` and `history --format {{.Size}}` (#17767, #17768)

[rbagd]

CI indicates that one of the bats tests failed, namely podman image history Created. Besides a regex check which is fixable, it also requires that podman image list --format {{.CreatedAt}} would be the same as podman image history --format {{.CreatedAt}}. But Docker itself outputs them in a different format, so it's unclear now if this comparison should be dropped to favor docker compatibility... 🤷‍♂️

Assuming PR is merged,

$ docker image list --format {{.CreatedAt}} busybox | head -n 1
2023-03-17 02:35:43 +0100 CET
$ docker image history --format {{.CreatedAt}} busybox | head -n 1
2023-03-17T02:35:43+01:00

$ podman image list --format {{.CreatedAt}} busybox | head -n 1
2023-03-17 01:35:43 +0000 UTC
$ podman image history --format {{.CreatedAt}} busybox | head -n 1
2023-03-17T02:35:43+01:00

[rhatdan]

I am fine with fixing this, but I will allow @vrothberg and @mheon to chime in.

[mheon]

I'd prefer to retain the test - it seems like it could be changed to parse the fields back to a time.Time and compare them that way. LGTM otherwise.

[vrothberg]

The changes look good to me.

One system test isn't passing (see https://cirrus-ci.com/task/5421900956958720?logs=main#L284). @edsantiago, we probably need to your scripting skills. I tried normalizing the two dates but one fails with

$ date -d '2022-10-18 16:28:08 +0000 UTC'

[edsantiago]

The failing system test is: CreatedSince and CreatedAt from image history should == image list. TL;DR this PR makes podman image list and podman image history inconsistent with each other:

$ for i in list history;do echo;bin/podman image $i --format '{{.CreatedAt}}' quay.io/libpod/testimage:20221018;done

2022-10-18 16:28:08 +0000 UTC     <--- until now, this has been the format for both

2022-10-18T10:28:08-06:00         <--- new, changed format
2022-10-18T10:28:08-06:00
2022-10-18T10:28:08-06:00
2022-10-18T10:28:08-06:00
2022-10-18T10:28:20-06:00
2022-10-18T10:28:20-06:00
2022-10-18T10:28:20-06:00

[eriksjolund]

In the commit message it's written

Closes #17767 and #17768 

The GitHub linking only works for the first one (17767) but not the second one (17768)

I would guess the commit message needs to be written like this for it to work

Closes #17767
Closes #17768 

Quote:

Multiple issues	Use full syntax for each issue

from
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

[rbagd]

I updated the relevant system test to maintain the equality check of podman image history and podman image list output for CreatedAt and CreatedSince. Please let me know if this looks good enough. To make the whole thing more readable I switched field separator in the test to ; from --.

[Luap99]

@edsantiago PTAL at system tests

[edsantiago]

LGTM. Thanks @rbagd.

@containers/podman-maintainers PTAL, especially the docker compatibility (I don't have a good way to test docker).

[eriksjolund]

@rbagd Thanks for adjusting the commit message so that it now says

Closes #17767
Closes #17768

Unfortunately it didn't fix the the GitHub linking. Sorry for my misleading information.
I made a test in another GitHub repository and saw that we can fix the GitHub linking by editing the pull request's description and replace

Closes #17767 and #17768

with

Closes #17767
Closes #17768

[rbagd]

It seems to be working! Both issues appear on the right sidebar now as expected.

[TomSweeneyRedHat]

LGTM

[rhatdan]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rbagd, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment