Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Final release notes for v4.5.0 #18199

Closed
wants to merge 2 commits into from
Closed

[CI:DOCS] Final release notes for v4.5.0 #18199

wants to merge 2 commits into from

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Apr 14, 2023

Does this PR introduce a user-facing change?

None

@ashley-cui @mheon PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

@rhatdan PTAL

@lsm5 lsm5 mentioned this pull request Apr 14, 2023
Merged
@Luap99
Copy link
Member

Luap99 commented Apr 14, 2023

#18195 was just merged please rebase your PRs to pick that up

@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

#18195 was just merged please rebase your PRs to pick that up

great, thanks @Luap99

@Luap99
Copy link
Member

Luap99 commented Apr 14, 2023

I think we also forgot to mention in the release notes that DHCP with macvlan and the netavark backend is now supported.

@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

I think we also forgot to mention in the release notes that DHCP with macvlan and the netavark backend is now supported.

ack, I'll add that.

@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

#18195 was just merged please rebase your PRs to pick that up

doesn't look merged yet, merge bot is taking its time. Never mind.

@lsm5 lsm5 force-pushed the v4.5.0-release-notes branch from fa1ba0b to 9d092ed Compare April 14, 2023 12:43
@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

@Luap99 PTAL

Luap99
Luap99 reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

LGTM

Thanks @Luap99 . @mheon @ashley-cui if this PR is good to go, I guess I could close it and include the changes in #18200 itself . Either way..

@mheon
Copy link
Member

mheon commented Apr 14, 2023

@lsm5 Close + cherry-pick into #18200 SGTM. Change LGTM

ashley-cui
ashley-cui reviewed Apr 14, 2023
View reviewed changes
RELEASE_NOTES.md Outdated Show resolved Hide resolved
@ashley-cui
Copy link
Member

Other than that, LGTM. Would be ok with this in the other PR

@lsm5 @ashley-cui
Update RELEASE_NOTES.md
21d2cf8 
Co-authored-by: Ashley Cui <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

Other than that, LGTM. Would be ok with this in the other PR

Done. Moving it to the release PR.

@lsm5 lsm5 closed this Apr 14, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
@lsm5 lsm5 deleted the v4.5.0-release-notes branch October 25, 2024 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@ashley-cui ashley-cui ashley-cui left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsm5 @Luap99 @mheon @ashley-cui