fix: Document removing anonymous volumes at create #18151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[NO NEW TESTS NEEDED] Signed-off-by: Park Jaeon <[email protected]>
openshift-ci
bot
added
the
approved
Luap99
approved these changes
Apr 12, 2023
Comment on lines
+319
to
+320
| Automatically remove the container and any anonymous unnamed volume associated with | ||
| the container when it exits. The default is **false**. |
There was a problem hiding this comment.
Ideally this should really be included with the @@option mechanism. So both podman-create and podman-run only need to write it once.
But I won't block this over it, the change is better so I am good to merge
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: finalchild, Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?
Omitted changes from #17793.
Note: I couldn't understand this part so I deleted it:
Remove container (and pod if created) after exit. The following sequence of commands didn't automatically remove the pod, while the container inside and the unnamed volume were removed.If someone can explain to me what this means, I could revert that change.