Return title fields as a list #18136
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
rhatdan
added
4.5
and removed
approved
github-actions
bot
added
the
kind/api-change
openshift-ci
bot
added
the
approved
|
Tests aren't happy. Let's not make this block 4.5. |
rhatdan
force-pushed
the
docker
branch
2 times, most recently
from
e83409a to
8052e70
Compare
Podman is attempting to split the headers returned by the ps command into a list of headers. Problem is that some headers are multi-word, and headers are not guaranteed to be split via a tab. This PR splits the headers bases on white space, and for the select group of CAPS headers which are multi-word, combines them back together. Fixes: containers#17524 Signed-off-by: Daniel J Walsh <[email protected]>
|
/cherry-pick v4.5 |
|
@mheon: once the present PR merges, I will cherry-pick it on top of v4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM |
|
/lgtm |
|
@mheon: new pull request created: #18191 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| for _, title := range strings.Fields(output) { | ||
| switch title { | ||
| case "AMBIENT", "INHERITED", "PERMITTED", "EFFECTIVE", "BOUNDING": | ||
| { | ||
| titles = append(titles, title+" CAPS") | ||
| } | ||
| case "CAPS": | ||
| continue | ||
| default: | ||
| titles = append(titles, title) | ||
| } |
There was a problem hiding this comment.
Can we somehow expose this in psgo? This looks rather hacky and will break every-time psgo adds a new header with space. cc @vrothberg
There was a problem hiding this comment.
This functionality doesn't look being tested. A flip in psgo wouldn't hurt.
There was a problem hiding this comment.
Are we guaranteed to go through psgo all the time, don't we sometimes still exec ps?
While a new "space" added filed could cause an issue, it would be only a bad formatting on screen, not an actual bug.
Moving this function to psgo makes sense or having psgo expose all of these fields so we could get the list from it would make sense.
github-actions
bot
added
the
locked - please file new issue/PR
Podman is attempting to split the headers returned by the ps
command into a list of headers. Problem is that some headers
are multi-word, and headers are not guaranteed to be split via
a tab. This PR splits the headers bases on white space, and for
the select group of CAPS headers which are multi-word, combines
them back together.
Fixes: #17524
Does this PR introduce a user-facing change?