Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image filter in list images API #18097

Closed
wants to merge 2 commits into from
Closed

Fix image filter in list images API #18097

wants to merge 2 commits into from

Conversation

TP-O
Copy link

@TP-O TP-O commented Apr 7, 2023

JSON filter input

{
    "label": [
        "org.opencontainers.image.ref.name=ubuntu", 
        "org.opencontainers.image.version=22.04"
    ]
}

ImageListOptions.Filter is generated

["label=org.opencontainers.image.ref.name=ubuntu=org.opencontainers.image.version=22.04"]

After fix

["label=org.opencontainers.image.ref.name=ubuntu", "label=org.opencontainers.image.version=22.04]

Close #18092

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TP-O
Once this PR has been reviewed and has the lgtm label, please assign baude for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TP-O TP-O closed this Apr 7, 2023
@TP-O TP-O reopened this Apr 7, 2023
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Apr 7, 2023
Signed-off-by: TP-O <[email protected]>
@TP-O TP-O closed this Apr 7, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/api-change Change to remote API; merits scrutiny locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Filtering Incompatability with Docker API
1 participant