Properly remove the service container during kube down #18086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
|
@vrothberg PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
umohnani8
force-pushed
the
detach
branch
2 times, most recently
from
06cdef7 to
95eceb7
Compare
|
LGTM |
vrothberg
reviewed
Apr 7, 2023
Ensure that we are actually looking up the service container ID and actually removing it during kube teardown for the --wait use case. This ensures that we don't have a service container waiting around in removing state before we return from kube play in the remote case. [NO NEW TESTS NEEDED] Signed-off-by: Urvashi Mohnani <[email protected]>
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
LGTM and happy green test buttons. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we are actually looking up the service container ID and actually removing it during kube teardown for the --wait use case. This ensures that we don't have a service container waiting around in removing state before we return from kube play in the remote case.
Should fix #17803
Does this PR introduce a user-facing change?