Cirrus: Enable labeling of EC2 VMs #18072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually confirmed, in EC2 I see an instanced with the name-tag 'cirrus-task-5740157471555584` for the aarch64 build task. |
In GCP, user specified VM names are required upon creation. Cirrus-CI generates helpful names containing the task-ID. Unfortunately in EC2 the VM ID's are auto-generated, and special permissions are required to allow secondary setting of a `Name` tag. Since this permission has been granted, enable the `experimental` flag on EC2 tasks so that cirrus can update VM name-tags. This is especially useful in troubleshooting orphaned VMs. Ref: containers#18065 (comment) Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
enable_ec2_experimental
branch
from
c856853 to
56e7b51
Compare
|
force-push: rebased |
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GCP, user specified VM names are required upon creation. Cirrus-CI generates helpful names containing the task-ID. Unfortunately in EC2 the VM ID's are auto-generated, and special permissions are required to allow secondary setting of a
Nametag. Since this permission has been granted, enable theexperimentalflag on EC2 tasks so that cirrus can update VM name-tags. This is especially useful in troubleshooting orphaned VMs.Ref:
#18065 (comment)
Does this PR introduce a user-facing change?