Cirrus: Fix aarch64 clone_script 404 errors #18069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsantiago
reviewed
Apr 5, 2023
Fixes: containers#18040 If the `build_aarch64` task happens to fail for any reason, it will cause the `curl` command in the `clone_script` for the aarch64 system test tasks to throw a 404. This is because the `local_system_test_aarch64_task` depends on `build` not `build_aarch64`. As discovered in another issue long ago, the Cirrus API depends on doing some dependency-resolution magic to function properly. Fix this by correcting the dependencies. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
fix_build_aarch64_dep
branch
from
5383a24 to
74f9fd8
Compare
edsantiago
approved these changes
Apr 5, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm Thanks again @cevich |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18040
If the
build_aarch64task happens to fail for any reason, it will cause thecurlcommand in theclone_scriptfor the aarch64 system test tasks to throw a 404. This is because thelocal_system_test_aarch64_taskdepends onbuildnotbuild_aarch64. As discovered in another issue long ago, the Cirrus API depends on doing some dependency-resolution magic to function properly. Fix this by correcting the dependencies.Does this PR introduce a user-facing change?