test updates to help debug #18041 #18043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard lib states that server handlers don't need to close the body, so let's not do that to avoid any unforeseen side effect. [NO TESTS NEEDED] - existing tests should suffice. Signed-off-by: Valentin Rothberg <[email protected]>
Check the DELETE reports for both deletes. containers#18041 indicates that the pod hasn't been removed which made me suspicious about the 1st delete. Signed-off-by: Valentin Rothberg <[email protected]>
Don't check for `.Pods` field in DELETE reports since they don't exist. Signed-off-by: Valentin Rothberg <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
release-note-none
and removed
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
kind/api-change
|
Good catch, thank you. |
|
@containers/podman-maintainers PTAL |
|
/lgtm Autotagbot added the "API change" label because the PR touches files under |
openshift-ci
bot
added
the
do-not-merge/hold
|
I think it got marked as an API change because code in the handler got changed. The API itself remained untouched. @Luap99 PTAL |
|
/hold cancel |
edsantiago
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details. Given the first DELETE didn't actually check if the pod was removed, we may get some better idea on the next flakes.
@edsantiago, that's the best thing I could come up with. PTAL
Does this PR introduce a user-facing change?