[wip] cp.go: docker compat w/ --follow-link option #18020
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danishprakash <[email protected]>
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danishprakash The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
A friendly reminder that this PR had no activity for 30 days. |
|
@danishprakash are you still working on this? |
|
Hey @rhatdan, this PR just adds the cli option, the major work is being done over at containers/buildah#4703. If you could please take a look at that whenever you've a moment, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman cp, by default follows link when there's a symlink that's supposed to be copied to a container. This is docker's behavior with
--follow-linkflag. This PR changes the default behaviour to conform to docker's and adds the--follow-linkflag to cp to follow links (current behaviour).Relies on containers/buildah#4703
Closes #16585