quadlet: implement Tmpfs option
#17993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not manage to run the bats tests locally. Hopefully this is done by CI. |
|
Try |
|
I got it working. Thanks @edsantiago |
vrothberg
reviewed
Apr 3, 2023
There was a problem hiding this comment.
Thanks for contributing!
LGTM
@ygalblum @alexlarsson @rhatdan PTAL
ygalblum
reviewed
Apr 3, 2023
This commit adds an quadlet option `Tmpfs` which can be used to mount a tmpfs in the container. Closes #17907 Signed-off-by: Cedric Staniewski <[email protected]>
|
Were beginning to cut podman 4.5, would be nice to get this in. |
|
Rerun the flaked tests |
openshift-ci
bot
added
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Luap99
approved these changes
Apr 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, xduugu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This was referenced Apr 4, 2023
This was referenced Apr 5, 2023
Closed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an quadlet option
Tmpfswhich can be used to mount a tmpfs in the container.Closes #17907
Does this PR introduce a user-facing change?