Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:BUILD] Packit: Initial Enablement #17898

Merged
merged 1 commit into from
Apr 13, 2023
Merged

[CI:BUILD] Packit: Initial Enablement #17898

merged 1 commit into from
Apr 13, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Mar 23, 2023 •
edited
Loading

This commit adds Packit configuration files which will trigger rpm builds on copr:rhcontainerbot/packit-builds on every PR as well as on copr:rhcontainerbot/podman-next on every commit to main branch.

This commit will ensure main branch is always buildable on all supported Fedora and CentOS Stream versions for aarch64 and x86_64. TODO: enable build checks for s390x and ppc64le while ensuring they don't take too long to build.

The packit builds reuse buildah.spec.rpkg present upstream and are thus independent of Fedora / CentOS dist-git.

This change will remove the need for the current webhook based triggering of rpm builds on rhcontainerbot/podman-next after commit to main. That will be instead handled by the trigger: commit action added in this PR. New builds will continue to get posted to the same link so users don't need to change any existing copr repo configuration.

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

EDIT: I plan to run packit copr-builds for about a week, twice at least everyday, and report back with the build and total times for every run, so reviewers can feel at ease RE: total gating time.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Mar 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2023
@lsm5
Copy link
Member Author

lsm5 commented Mar 23, 2023 •
edited
Loading

Run 1.
build time: 12 mins
total time: 18 mins

https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/5698663/

@lsm5 lsm5 changed the title [CI:BUILD] Packit: Initial Enablement [DO NOT MERGE] [CI:BUILD] Packit: Initial Enablement Mar 23, 2023
@lsm5
Copy link
Member Author

lsm5 commented Mar 23, 2023

/packit copr-build

@lsm5
Copy link
Member Author

lsm5 commented Mar 23, 2023

Run 2.
build time: 9 mins
total time: 13 mins

https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/5698800/

@lsm5
Copy link
Member Author

lsm5 commented Mar 24, 2023

/packit copr-build

@lsm5 lsm5 force-pushed the packit-copr-builds branch from 72787c7 to 410b139 Compare March 24, 2023 06:45
@lsm5
Copy link
Member Author

lsm5 commented Mar 24, 2023 •
edited
Loading

Run 3.
build time: 8 mins
total time: 12 mins

https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/5702881/

@lsm5 lsm5 force-pushed the packit-copr-builds branch from 410b139 to f55e3e3 Compare March 24, 2023 09:03
@lsm5
Copy link
Member Author

lsm5 commented Mar 24, 2023

Run 4.
build time: 9 mins
total time: 14 mins

https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/5703342/

@lsm5
Copy link
Member Author

lsm5 commented Mar 24, 2023

/packit copr-build

@lsm5
Copy link
Member Author

lsm5 commented Mar 24, 2023

Run 5.
build time: 8 mins
total time: 12 mins

https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/5703503/

@TomSweeneyRedHat
Copy link
Member

I"m still not packit expert, or even a newbie, but it looks reasonable, and I like the shrinking test times.

@lsm5 lsm5 force-pushed the packit-copr-builds branch from f55e3e3 to 51cbbb5 Compare March 31, 2023 10:04
@lsm5
Copy link
Member Author

lsm5 commented Mar 31, 2023

Run 6.
build time: 9 mins
total time: 12 mins

https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/5732455/

@lsm5
Copy link
Member Author

lsm5 commented Mar 31, 2023

I"m still not packit expert, or even a newbie, but it looks reasonable, and I like the shrinking test times.

@TomSweeneyRedHat thanks, I'll give it a few more runs and hopefully we can then get this in assuming everyone's convinced.

@lsm5 lsm5 force-pushed the packit-copr-builds branch from 51cbbb5 to 1001eac Compare April 3, 2023 08:53
@lsm5
Copy link
Member Author

lsm5 commented Apr 3, 2023

Run 7.
build time: 1 hr 12 mins
total time: 1 hr 16 mins

https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/5738236/

Something's been up with centos-stream today

@lsm5
Copy link
Member Author

lsm5 commented Apr 3, 2023

/packit copr-build

@lsm5
Copy link
Member Author

lsm5 commented Apr 3, 2023

There's gonna be a copr outage on Apr 5, lasting 3 hours: https://pagure.io/fedora-infrastructure/issue/11201

@lsm5 lsm5 force-pushed the packit-copr-builds branch from 1001eac to 6e8c3a9 Compare April 5, 2023 07:09
@lsm5
Copy link
Member Author

lsm5 commented Apr 5, 2023

/packit copr-build

1 similar comment
@lsm5
Copy link
Member Author

lsm5 commented Apr 5, 2023

/packit copr-build

@lsm5 lsm5 force-pushed the packit-copr-builds branch from 6e8c3a9 to 5005cb1 Compare April 11, 2023 18:22
@lsm5
Copy link
Member Author

lsm5 commented Apr 11, 2023

/packit copr-build

@lsm5 lsm5 force-pushed the packit-copr-builds branch from 5005cb1 to 22be1bb Compare April 11, 2023 18:54
@lsm5
Copy link
Member Author

lsm5 commented Apr 11, 2023

Run 8.
build time: 7 mins
total time: 13 mins

https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/5773693/

@lsm5
Copy link
Member Author

lsm5 commented Apr 11, 2023

/packit copr-build

@lsm5
Copy link
Member Author

lsm5 commented Apr 12, 2023

Run 9.
build time: 8 mins
total time: 12 mins

https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/5773776/

@lsm5 lsm5 force-pushed the packit-copr-builds branch from 22be1bb to 65eb93b Compare April 12, 2023 17:42
@edsantiago
Copy link
Member

Thanks, @lsm5. The hour-plus event last week is pretty much what I expect to see occasionally. If we can live with that, LGTM.

@lsm5
[CI:BUILD] Packit: Initial Enablement
be14866 
This commit adds Packit configuration files which will trigger rpm
builds on copr:`rhcontainerbot/packit-builds` on every PR as well as on
copr:`rhcontainerbot/podman-next` on every commit to main branch.

This commit will ensure main branch is always buildable on all supported
Fedora and CentOS Stream versions for aarch64 and x86_64.
TODO: enable build checks for s390x and ppc64le while ensuring they
don't take too long to build.

The packit builds reuse `buildah.spec.rpkg` present upstream and are
thus independent of Fedora / CentOS dist-git.

This change will remove the need for the current webhook based triggering
of rpm builds on rhcontainerbot/podman-next after commit to main.
That will be instead handled by the `trigger: commit` action added in this
PR. New builds will continue to get posted to the same link so users
don't need to change any existing copr repo configuration.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the packit-copr-builds branch from 65eb93b to be14866 Compare April 13, 2023 12:43
@lsm5 lsm5 marked this pull request as ready for review April 13, 2023 12:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2023
@lsm5 lsm5 changed the title [DO NOT MERGE] [CI:BUILD] Packit: Initial Enablement [CI:BUILD] Packit: Initial Enablement Apr 13, 2023
@lsm5
Copy link
Member Author

lsm5 commented Apr 13, 2023

Thanks, @lsm5. The hour-plus event last week is pretty much what I expect to see occasionally. If we can live with that, LGTM.

@edsantiago happy to hear that, thanks! I've marked it ready for review now. Please give it a slash-lgtm if you're comfy.

@containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented Apr 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 37cdc2b into containers:main Apr 13, 2023
@lsm5 lsm5 deleted the packit-copr-builds branch April 13, 2023 19:00
@lsm5 lsm5 mentioned this pull request Aug 4, 2023
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lsm5 @TomSweeneyRedHat @edsantiago @mheon @openshift-merge-robot