Use lowercase "id" in stats API, for Docker compatibility

[kierendavies]

Fixes #17869

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

Changed stats API response `"Id"` to `"id"`, for Docker compatibility

[rhatdan]

LGTM
@vrothberg PTAL
/approve
Thanks @kierendavies

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kierendavies, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

Thanks for the patch, while the change is correct for the docker API it is not correct for the libpod API because this might break existing users and we use the same endpoint for both, see

podman/pkg/api/server/register_containers.go

Line 1118 in 74c5a01

r.HandleFunc(VersionedPath("/libpod/containers/{name}/stats"), s.APIHandler(compat.StatsContainer)).Methods(http.MethodGet)

So you need to add a new type for it and then you can check inside the API handler function with utils.IsLibpodRequest(r) if it was a libpod or docker API request and use the correct type.

Second, please do not use [NO NEW TESTS NEEDED], changes like that can and should be tested. The label is only meant for things that cannot be tested. Take a look at test/apvi2 to see some existing API tests.

[kierendavies]

please do not use [NO NEW TESTS NEEDED]

My apologies @Luap99! My reasoning was that a test for a specific field name is really just a duplicate of the definition of that field name.

Adding a new type affects code organisation, so I think I'd best leave those changes to someone more familiar with the norms of this codebase (or with more time to become familiar).

[Luap99]

No need to apologize, PRs are always welcome. For most endpoints this change would have been fine but not for this one.

I created #17890 to fix it without changing the libpod output. Feel free to test it.