logformatter: hide --db-backend #17855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
openshift-ci
bot
added
do-not-merge/hold
edsantiago
force-pushed
the
logformatter_db_backend
branch
from
2c618d6 to
9ee765f
Compare
* There's a new --db-backend option. Hide it, and actually just assume that any new --foo-backend option will have an arg that needs to be hidden. * Friendly-ize "Running: quadlet ..." because those messages include a "with QUADLET_FOO=bar" string that looks like it's part of the command line but is not, and it's really hard for a human eye to see what's command line and what's extra comment. Add tests. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
logformatter_db_backend
branch
from
9ee765f to
5447e88
Compare
|
I removed the LGTM tag because I discovered more work to be done, basically, formatting I updated commit message and github description to reflect new changes. |
edsantiago
removed
the
do-not-merge/hold
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a new --db-backend option. Hide it, and actually
just assume that any new --foo-backend option will
have an arg that needs to be hidden.
Friendly-ize "Running: quadlet ..." because those messages
include a "with QUADLET_FOO=bar" string that looks like
it's part of the command line but is not, and it's really
hard for a human eye to see what's command line and what's
extra comment.
Add tests.
Signed-off-by: Ed Santiago [email protected]