Reveal magic, parallel system-testing and system-testing simplification #1780
Conversation
cevich
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
cevich
force-pushed
the
un-magic
branch
19 times, most recently
from
0806628 to
1642549
Compare
|
DO NOT MERGE: There is still a bug in cirrus, I am in contact with their engineering and working on a fix. They're typically really fast with these things, expect resolution today / early next week. |
|
PASSES all test. |
|
@rhatdan thanks for taking a look. There are some not-so-obvious systemic bugs I need to work out. Hence the WIP and DO NOT MERGE. There's no better way to beat on the CI system than from w/in a PR, so there's a bunch of duct-tape in here temporarily. I'll strip all that out when the code is more solid (it's almost there). |
cevich
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Update: Cirrus bug has been fixed, this PR is ready to go, PTAL. (Assuming happy tests) |
|
Okay, this is working as designed: Having the magic words in the description caused this run to happen: https://cirrus-ci.com/task/5163575452631040 <-- Failed due to missing system tests (we know this). |
Previously, several magic strings were in place to affect cirrus-ci operations. Two were buried within scripts. One to optionally execute system-tests within a PR. Another to avoid re-building cache-images upon every merge. Move these magic strings out into the open, buy locating their logic up-front in the ``.cirrus.yml`` file. This improves readability and reduces surprise/astonishment at runtime. Signed-off-by: Chris Evich <[email protected]>
Previously it was required to call the verify, unit, and integration scripts in order to build/install dependencies, and libpod. This wastes time during the (optional) system-testing, since the actual unit/integration testing is also happening in parallel. Consolidate only the distribution-specific build steps into the system-testing script. This way, only the required steps are performed in their respective (parallel) tasks. Signed-off-by: Chris Evich <[email protected]>
***CIRRUS: REBUILD IMAGES*** Signed-off-by: Chris Evich <[email protected]>
|
Removed magic string, rebased and |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM too |
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Previously, several magic strings were in place to affect cirrus-ci
operations. Two were buried within scripts. One to optionally
execute system-tests within a PR. Another to avoid re-building
cache-images upon every merge.
Move these magic strings out into the open, buy locating their
logic up-front in the
.cirrus.ymlfile. This improvesreadability and reduces surprise/astonishment at runtime.
Previously it was required to call the verify, unit, and integration
scripts in order to build/install dependencies, and libpod. This
wastes time during the (optional) system-testing, since the
actual unit/integration testing is also happening in parallel.
Consolidate only the distribution-specific build steps into the
system-testing script. This way, only the required steps are performed
in their respective (parallel) tasks.