[v4.4.1-rhel] Use append() to add elements to a slice (restore) #17790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports containers#17755 from @adrianreber to fix an append issue. Will be used for a ZeroDay delivery to RHEL 8.8/9.2. Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2177611 Original commit message: The code was not using append() to add items to a slice. Accessing non allocated elements of the slice failed with: ``` $ podman container restore -l panic: runtime error: index out of range [0] with length 0 goroutine 1 [running]: github.com/containers/podman/v4/pkg/domain/infra/abi.(*ContainerEngine).ContainerRestore(0xc00051a8b8, {0x1dbced0, 0xc0000440d0}, {0x2a31b30, 0x0, 0x0}, {0x0, 0x0, 0x0, 0x0, ...}) /share/go/src/github.com/containers/podman/pkg/domain/infra/abi/containers.go:676 +0x39c github.com/containers/podman/v4/cmd/podman/containers.restore(0x28fb6c0?, {0xc0002c9080, 0x0, 0x1?}) /share/go/src/github.com/containers/podman/cmd/podman/containers/restore.go:171 +0x4ef github.com/spf13/cobra.(*Command).execute(0x28fb6c0, {0xc0000400b0, 0x1, 0x1}) /share/go/src/github.com/containers/podman/vendor/github.com/spf13/cobra/command.go:916 +0x862 github.com/spf13/cobra.(*Command).ExecuteC(0x291ab00) /share/go/src/github.com/containers/podman/vendor/github.com/spf13/cobra/command.go:1044 +0x3bd github.com/spf13/cobra.(*Command).Execute(...) /share/go/src/github.com/containers/podman/vendor/github.com/spf13/cobra/command.go:968 github.com/spf13/cobra.(*Command).ExecuteContext(...) /share/go/src/github.com/containers/podman/vendor/github.com/spf13/cobra/command.go:961 main.Execute() /share/go/src/github.com/containers/podman/cmd/podman/root.go:107 +0xcc main.main() /share/go/src/github.com/containers/podman/cmd/podman/main.go:41 +0x7c ``` [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <[email protected]>
openshift-ci
bot
added
release-note-none
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #17755 from @adrianreber to fix an append issue. Will be used for a ZeroDay delivery to RHEL 8.8/9.2.
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2177611
Original commit message:
The code was not using append() to add items to a slice.
Accessing non allocated elements of the slice failed with:
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?