Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman.spec.rpkg: distro conditionals for modulesloaddir #17725

Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Mar 9, 2023

RHEL 8 and 9 don't have /usr/lib/modules-load.d yet.

Related dist-git commit:
https://src.fedoraproject.org/rpms/podman/c/c82d37a5b3c102088775e16bca817437e425b5d1

Does this PR introduce a user-facing change?

None

@containers/podman-maintainers PTAL

RHEL 8 and 9 don't have /usr/lib/modules-load.d yet.

Related dist-git commit:
https://src.fedoraproject.org/rpms/podman/c/c82d37a5b3c102088775e16bca817437e425b5d1

Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@lsm5
Copy link
Member Author

lsm5 commented Mar 9, 2023

the rhel >= 10 will be used for ELN builds.

@rhatdan
Copy link
Member

rhatdan commented Mar 9, 2023

LGTM

@Luap99
Copy link
Member

Luap99 commented Mar 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit 80be8c3 into containers:main Mar 9, 2023
@lsm5 lsm5 deleted the modulesload-conditional-rhel10 branch March 16, 2023 11:25
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants