Cirrus: Fix git config permission denied #17659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buildah bud tests run rootless, so attempting to bypass the ident-check with a `git config --system` fails with a permission denied error (as it should). Update the command to use `--global` instead, which writes to `~/.gitconfig` and so works for regular users. Also setup a fake identity for the CI-user and enable shell-debugging for the commands to inform humans of what is happening in the script. Signed-off-by: Chris Evich <[email protected]>
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
/approve |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, lsm5, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhatdan
removed
do-not-merge/release-note-label-needed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #17643
The buildah bud tests run rootless, so attempting to bypass the ident-check with a
git config --systemfails with a permission denied error (as it should). Update the command to use--globalinstead, which writes to~/.gitconfigand so works for regular users.Also setup a fake identity for the CI-user and enable shell-debugging for the commands to inform humans of what is happening in the script.
Does this PR introduce a user-facing change?