sqlite updates #17658
Merged
sqlite updates #17658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Code LGTM |
Use the same error message as the boltdb backend. [NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <[email protected]>
I wasn't able to find a way to get error-checks working with the sqlite3 library with the time at hand. [NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <[email protected]>
It's `UPDATE $NAME` not `UPDATE TABLE $NAME`. [NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <[email protected]>
Wrap the error with the message expexted by the system tests. [NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <[email protected]>
A partial name match is tricky as we want it to be fast but also make sure there's only one partial match iff there's no full one. [NO NEW TESTS NEEDED] as it fixes a system test. Signed-off-by: Valentin Rothberg <[email protected]>
[NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <[email protected]>
There's a unique constraint in the table, so we shouldn't add the same volume more than once to the same container. [NO NEW TESTS NEEDED] as it fixes an existing one. Signed-off-by: Valentin Rothberg <[email protected]>
Found by golangci-lint. Signed-off-by: Valentin Rothberg <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>
|
/hold |
openshift-ci
bot
added
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of commits to the WIP sqlite backend in libpod. Please see the individual commits for details.
On my machine all but one system test pass. There is one remaining issue with respect to network aliases. Run the tests against
test/system/500-networking.bats --filter "connect/disconnect with port forwarding"to reproduce the issue. I am running out of time today, so I prefer to push the current state.@mheon @baude PTAL
Does this PR introduce a user-facing change?