-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Skip all pasta tests" #17650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, sbrivio-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There's probably some other issue here, checking versions etc. |
@cevich the version of passt here is |
Never mind, my bad, I didn't commit that change. |
They include passt-0^20230222.g4ddbcb9-1.fc37, so that we can re-enable pasta tests, and passt-0.0~git20230216.4663ccc-1, so that we can run them on Debian Sid. Signed-off-by: Stefano Brivio <[email protected]>
This reverts commit 81f116c: the passt package for Fedora 37 images is now fixed in the c20230223t153813z-f37f36d12 image. Signed-off-by: Stefano Brivio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/hold
Please remove WIP from heading if this is ready to merge. |
@Luap99 I guess you retriggered the "sys podman debian-12 rootless host" test, thanks! That failed twice with:
...are the tests triggering a more general timeout, not for the specific test case? Let me know if there's anything I can debug. Needless to say, I can consistently run these tests on current Debian Bookworm (current testing) with Podman and passt packages from Sid (unstable). :( |
Sorry, not my day. The re-run actually passed, I was following the wrong link. |
@rhatdan sure, I'm just waiting for a couple of tests to finish. |
I rerun "sys podman debian-12 rootless host" because of this error:
Seems to be a flake and unrelated to this change so I good with merging, if you saw actual timeouts in the pasta tests we should double check. |
No, no timeouts, I just saw a truncated log for a while, in the run you triggered it's all fine. |
ok |
This reverts commit 81f116c: the passt package for Fedora 37 images is now fixed in the c20230223t153813z-f37f36d12 image.
Does this PR introduce a user-facing change?