-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove replicas field from kubernetes deployment support doc #17636
Remove replicas field from kubernetes deployment support doc #17636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@containers/podman-maintainers PTAL
Should we add information that replicas are ignored if > 1, IE Use of replicas within a spec file, will not cause a failure. As I understand it. |
LGTM |
You are correct, so maybe we should use something else, e.g.: or via a footnote? |
I like the way you wrote it here, rather then footnote. |
@rhatdan Yes I agree. Footnotes are cumbersome for the reader. In any case, I wouldn't remove the supported sign because it might confuse users to think that podman will fail if the field is set |
+1 that looks good |
Replicas are ignored since containers#17082 Signed-off-by: Dan Čermák <[email protected]>
d1590ec
to
6d352dc
Compare
I've adjusted the text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcermak, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
Support for this field has been effectively removed via #17082, this addresses the issue raised in #17082 (comment)
Does this PR introduce a user-facing change?