Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove replicas field from kubernetes deployment support doc #17636

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

dcermak
Copy link
Contributor

@dcermak dcermak commented Feb 27, 2023

Support for this field has been effectively removed via #17082, this addresses the issue raised in #17082 (comment)

Does this PR introduce a user-facing change?

None

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@containers/podman-maintainers PTAL

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 27, 2023

Should we add information that replicas are ignored if > 1, IE Use of replicas within a spec file, will not cause a failure. As I understand it.

@umohnani8
Copy link
Member

LGTM

@dcermak
Copy link
Contributor Author

dcermak commented Feb 27, 2023

Should we add information that replicas are ignored if > 1, IE Use of replicas within a spec file, will not cause a failure. As I understand it.

You are correct, so maybe we should use something else, e.g.:
| replicas | ✔️ (the actual replica count is ignored and set to 1) |

or via a footnote?

@rhatdan
Copy link
Member

rhatdan commented Feb 28, 2023

I like the way you wrote it here, rather then footnote.
WDYT @vrothberg @umohnani8 @ygalblum

@ygalblum
Copy link
Contributor

@rhatdan Yes I agree. Footnotes are cumbersome for the reader. In any case, I wouldn't remove the supported sign because it might confuse users to think that podman will fail if the field is set

@vrothberg
Copy link
Member

I like the way you wrote it here, rather then footnote. WDYT @vrothberg @umohnani8 @ygalblum

+1 that looks good

@dcermak
Copy link
Contributor Author

dcermak commented Feb 28, 2023

I've adjusted the text.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcermak, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ygalblum
Copy link
Contributor

LGTM
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4b93662 into containers:main Feb 28, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants