Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: new rootless buildah-bud tests (cron only) #17608

Merged
merged 1 commit into from
Feb 23, 2023
Merged

CI: new rootless buildah-bud tests (cron only) #17608

merged 1 commit into from
Feb 23, 2023

Conversation

edsantiago
Copy link
Member

Run rootless bud tests as part of the nightly treadmill job.

Reason: #17480 could have been caught before release.

Signed-off-by: Ed Santiago [email protected]

None

@edsantiago edsantiago requested a review from cevich February 22, 2023 20:30
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 22, 2023
@edsantiago
Copy link
Member Author

I will be on PTO once the first results of this come in. If that's too high-risk for the team, I'm fine with this waiting.

@rhatdan
Copy link
Member

rhatdan commented Feb 23, 2023

LGTM
The cron tests are not blocking correct?

@edsantiago
Copy link
Member Author

Correct. Not only are they not blocking, they probably won't even be noticed by anyone.

cevich
cevich approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One "maybe" de-duplication suggestion. It's not critical though.

.cirrus.yml Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cevich
Copy link
Member

cevich commented Feb 23, 2023

Correct. Not only are they not blocking, they probably won't even be noticed by anyone.

They DO pop up when they fail on our podman-monitor e-mails. I'm not opposed to taking action, I'm just ignorant of what that should be. Best I've got is: If it breaks a lot, fwd the notice to the team. Maybe that's good enough?

@edsantiago if you have time, would you consider adding an idem to our podman-monitor cheat-sheet for how you'd like failures handled?

@edsantiago edsantiago force-pushed the rootless_bud_tests_in_cron branch from e224e2f to 1b654e5 Compare February 23, 2023 16:34
@edsantiago
Copy link
Member Author

Done: added a bullet item to the cheat sheet. (If treadmill ever fails with a non-flake, everyone needs to know about it)

@edsantiago
CI: new rootless buildah-bud tests (cron only)
5a08dda 
Run rootless bud tests as part of the nightly treadmill job.

Reason: containers#17480 could have been caught before release.

Also: refactored bot this and bud_test_task (the task which
I copypasted to form this one) to use *stdenvars; thanks
@cevich for catching that.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago force-pushed the rootless_bud_tests_in_cron branch from 1b654e5 to 5a08dda Compare February 23, 2023 17:27
@cevich
Copy link
Member

cevich commented Feb 23, 2023

Thanks @edsantiago We'll keep a closer eye on the job while you're out, (cc: @lsm5).

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 23, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6e64959 into containers:main Feb 23, 2023
@edsantiago edsantiago deleted the rootless_bud_tests_in_cron branch February 23, 2023 21:34
edsantiago added a commit to edsantiago/libpod that referenced this pull request Feb 24, 2023
@edsantiago
buildah-bud tests: don't sudo when rootless is desired
d838c08 
Followup to containers#17608, rootless buildah-bud in cron. I forgot
one crucial step, skipping the sudo.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago mentioned this pull request Feb 24, 2023
Merged
edsantiago added a commit to edsantiago/libpod that referenced this pull request Mar 13, 2023
@edsantiago
bud tests: rootless remote: use correct socket path
159936a 
Another followup to containers#17608. Nightly tests were hanging,
because /run/podman/podman.sock was hardcoded (bad idea
for rootless). Poor testing on my part.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago mentioned this pull request Mar 13, 2023
Merged
edsantiago added a commit to edsantiago/libpod that referenced this pull request Mar 15, 2023
@edsantiago
buildah treadmill: also run rootless tests
7ed1c7f 
In February we started running rootless bud tests in cron (containers#17608).
That's nice, but nobody ever looks at cron results. The idea behind
adding a rootless task was to run it in the manual treadmill, too.
This PR enables that, and more clearly documents the how and why.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago mentioned this pull request Mar 15, 2023
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cevich cevich cevich approved these changes

Assignees

@cevich cevich

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edsantiago @rhatdan @cevich @openshift-merge-robot