Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor c/common@852ca05a1fbb #17591

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

vrothberg
Copy link
Member

@edsantiago PTAL
@containers/podman-maintainers PTAL

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@edsantiago
Copy link
Member

In the title, don't you mean 852ca05a? Because that's the c-c commit (AFAICT) that incorporates your change, and that's the commit I see in your go.mod diffs. LGTM aside from the commit title.

Also force an update of c/image to prevent a downgrade.

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg changed the title vendor c/common@6f7e45b137bd vendor c/common@852ca05a1fbb Feb 21, 2023
@vrothberg
Copy link
Member Author

In the title, don't you mean 852ca05a? Because that's the c-c commit (AFAICT) that incorporates your change, and that's the commit I see in your go.mod diffs. LGTM aside from the commit title.

Updated. Thanks for catching! I updated the commit but forgot to reflect that in the commit title.

@edsantiago
Copy link
Member

Tests pass, so LGTM

@Luap99
Copy link
Member

Luap99 commented Feb 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit ea66c7b into containers:main Feb 21, 2023
@vrothberg vrothberg deleted the vendor-common branch February 21, 2023 15:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants