Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.4.1-rhel] [CI:DOCS] Touch up secret man page #17559

Conversation

TomSweeneyRedHat
Copy link
Member

This is a working theory fix. The man pages including the secret.md option are not resolving properly. The secret.md file is the only one with a text line with three back ticks on the start and end of the line. Elsewhere we have the backticks on separate lines and the text in its own line.

This might not fix the issue, but at the very least it makes things consistent.

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

This is a working theory fix.  The man pages including the
secret.md option are not resolving properly.  The secret.md
file is the only one with a text line with three back ticks on the start
and end of the line.  Elsewhere we have the backticks on separate lines
and the text in it's own line.

This might not fix the issue, but at the very least it makes things
consistent.

[NO NEW TESTS NEEDED]

Signed-off-by: tomsweeneyredhat <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@ashley-cui
Copy link
Member

Do we want to just backport this instead? https://github.com/containers/podman/pull/17544/files I think they do the same thing

@TomSweeneyRedHat
Copy link
Member Author

I found that one after I'd put this together @ashley-cui . As this has passed tests and the only other difference is a comment in the Makefile, I'd just push this through. But I'll let you and @mheon make the call on that.

Regardless, if we go forward with this one, it's got happy green test buttons.

@ashley-cui
Copy link
Member

If tests are happy, I'm happy :)

LGTM

@rhatdan
Copy link
Member

rhatdan commented Feb 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0b38633 into containers:v4.4.1-rhel Feb 18, 2023
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/fixsecret4.4.1 branch June 30, 2023 21:43
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants